Skip to content

✨ Support common pydantic types #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lachaib wants to merge 32 commits into
base: master
Choose a base branch
from
Open

✨ Support common pydantic types #723

lachaib wants to merge 32 commits into from
+474 −16

Conversation

@lachaib
Copy link

@lachaib lachaib commented Dec 21, 2023

This PR is "functional" as in "it does what was expected"

  • Support pydantic common types while keeping pydantic an optional dependency
  • Works in lists and tuples
  • Documentation with examples and test on examples

However, don't hesitate to request more tests, docs, or improvements on the code if needed to fit with the current standards

Fixes #181

@lachaib lachaib force-pushed the lachaib/issue181 branch 2 times, most recently from 23988ad to 08d1fac Compare December 21, 2023 13:11
@lachaib
Copy link
Author

lachaib commented Dec 21, 2023 •
edited
Loading

@tiangolo in order to add a basic pydantic support, we'd need to drop python 3.6, and I'd say it's about time 😏
Would you agree with that? Do you want me to open another pull request to do so? I'd be glad to help.

Edit: seems it's already submitted here #556

@svlandeg svlandeg added feature New feature, enhancement or request p3 labels Feb 28, 2024
@lachaib lachaib force-pushed the lachaib/issue181 branch 4 times, most recently from debccf1 to 2a48587 Compare March 28, 2024 22:36
@svlandeg
Copy link
Member

svlandeg commented Mar 29, 2024

@tiangolo in order to add a basic pydantic support, we'd need to drop python 3.6, and I'd say it's about time 😏

Hi! Note that Python 3.6 support was recently dropped in 0.11.0.

@lachaib

This comment was marked as resolved.

Sign in to view
@svlandeg

This comment was marked as resolved.

Sign in to view
@pypae pypae mentioned this pull request Apr 24, 2024
Draft
7 tasks
@pypae
Copy link

pypae commented Apr 26, 2024

Looks great, I'd love to see this get merged!

Could we somehow also support custom types defined by users like pydantic?

@lachaib
Copy link
Author

lachaib commented May 12, 2024

Looks great, I'd love to see this get merged!

Me too 😁

Could we somehow also support custom types defined by users like pydantic?

TBH I think this PR covers most of cases we need for now and I prefer to keep it minimalistic to get a chance for it to be merged soon.
On a personal project I managed to go a bit further and I'd really be glad to see Typer include all the features I made (some from inspiration of existing PRs) but small steps are always better.

@lachaib lachaib force-pushed the lachaib/issue181 branch 3 times, most recently from 0ac6ec0 to 707839e Compare May 17, 2024 09:39
@benglewis
Copy link

benglewis commented Jun 4, 2024

@tiangolo Is this PR being considered?

@svlandeg svlandeg added the dependencies Pull requests that update a dependency file label Jul 25, 2024
svlandeg
svlandeg reviewed Jul 25, 2024
View reviewed changes
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lachaib, thanks for this nice work! Really appreciate the detailed tests and documentation as well.

I'm going to spend some time going through this PR in detail - I might leave some more review comments in the process, and might also push a few changes directly to your branch 🙏

@svlandeg
Copy link
Member

svlandeg commented Jul 25, 2024 •
edited
Loading

It looks like this PR is now failing, as we recently added Python 3.12 to the CI. I'll put this in draft while we work on it 🚧

@svlandeg svlandeg marked this pull request as draft July 25, 2024 14:26
svlandeg
svlandeg reviewed Jul 25, 2024
View reviewed changes
svlandeg
svlandeg reviewed Jul 25, 2024
View reviewed changes
@lachaib lachaib marked this pull request as ready for review July 25, 2024 23:12
@svlandeg svlandeg changed the title [FEATURE] Support for common pydantic types ✨ Support common pydantic types Jul 26, 2024
@pypae pypae mentioned this pull request Jul 28, 2024
Merged
@lachaib
Copy link
Author

lachaib commented Jul 30, 2024

@svlandeg thanks for your additions, I'm wondering now what's next for this PR and how may we move forward to merging?

@svlandeg svlandeg marked this pull request as draft September 22, 2025 10:17
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2025 •
edited
Loading

📝 Docs preview

Last commit f7881f4 at: https://d445785f.typertiangolo.pages.dev

Modified Pages

@svlandeg svlandeg marked this pull request as ready for review October 3, 2025 16:02
@svlandeg svlandeg removed their assignment Oct 3, 2025
@svlandeg svlandeg marked this pull request as draft November 25, 2025 15:26
@svlandeg svlandeg self-assigned this Nov 25, 2025
@svlandeg svlandeg removed their assignment Nov 25, 2025
@svlandeg svlandeg marked this pull request as ready for review November 25, 2025 15:46
@github-actions github-actions bot added the conflicts Automatically generated when a PR has a merge conflict label Dec 25, 2025
@github-actions

This comment was marked as resolved.

Sign in to view
@svlandeg svlandeg self-assigned this Jan 7, 2026
@svlandeg svlandeg marked this pull request as draft January 7, 2026 14:21
@github-actions github-actions bot removed the conflicts Automatically generated when a PR has a merge conflict label Jan 13, 2026
@svlandeg svlandeg marked this pull request as ready for review January 13, 2026 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@svlandeg svlandeg svlandeg left review comments

Assignees

@svlandeg svlandeg

Labels

dependencies Pull requests that update a dependency file feature New feature, enhancement or request p3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE] Support for common pydantic types

5 participants

@lachaib @svlandeg @pypae @benglewis @tiangolo